This is sort of a shared question between engineering and UX. 2, but also store a bookmark annotation stating the page should be opened in reader-mode, and handle it like Open in Sidebar (also adding a checkbox to the bookmark properties panel) Though the page won't reopen into reader-modeģ.
#Bookmark feature in mailplane 4 code#
never bookmark reader mode, always bookmark the base url and always compare with the base url in all the code (this means updating not just the star state but also the panel code). when the page is bookmarked in reader mode, bookmark both the page and the reader mode page. it's generally dangerous to detach the indicator and the underlying code.ġ. that means clicking the starred icon would actually add a bookmark.
#Bookmark feature in mailplane 4 update#
I think it's not so easy, cause that woul just update the star state, but then when clicking it, it would behave considering the current location and not the star state.
> places.js#1496 to check both the about:reader prefix and sans-prefix, and (In reply to Jared Wein (please needinfo? me) from comment #2) ( Bug 1188380)Īnd sharing per mail produces a link that only works in Firefox which is not optimal either. (And possibly a prefix to the title to be identifiable.) Much like what pocket does as a web service.Ĭurrently in Reader View even our Share Plane is disabled because it is nothing that can be shared, which is strange as well as one would expect the article (not the view) to be shareable. If we want to treat the reader view of a page like a bookmark-able object itself, we have to give it more "pageness", meaning an own URL (visibly), and the ability to be accessible everywhere, not just in Firefox. And if we would mark both, the reader view version, and the page itself with one bookmark, how would the user know which it is, or what to expect when clicking a bookmark? When building reader view we decided to treat it as a view, much like zoom, page style or full-screen, none of which are represented in the bookmark. Therefor the bookmark should direct to the page itself, not the view the page was in when bookmarking. I assume it is the content, or for more technical users the URL, but not the view. Conceptual question there is what users think is being bookmarked: the content, the URL or the view. Yes, it would be nice if the user could return to what they originally bookmarked.
We could modify to check both the about:reader prefix and sans-prefix, and mark the star if either of them match. That being said, we should do something about indicating if the page has been bookmarked even when they're not in the reader view. If a user is reading a page using Reader View and then proceeds to bookmark it, when the user visits the bookmark later they should see what they were seeing when they bookmarked the page. I admit it's a bit confusing since the URL doesn't match what would be loaded if it were to be copy/pasted in to a fresh tab, but I think the behavior of storing the bookmark to the Reader Mode view is correct. > prefer having the ability to bookmark a page in RM, or it is not intuitive
> the original page, by clicking the "Close Reader View" button. > Does this count as a bug or a feature? The user still have a way to get to (In reply to Wei-Yin Chen from comment #1)
0 kommentar(er)
